Difference: ServiceWork (1 vs. 13)

Revision 1308 Jun 2010 - MatthewRose

Line: 1 to 1
 
META TOPICPARENT name="MatthewRose"
LearningCurve MatthewRose

Improving ATLAS Trigger code

Editing trigger code to meet ATLAS coding guidelines
Changed:
<
<

Changes Made

>
>

Packages

 

TrigEgammaHypo/

Revision 1208 Jun 2010 - MatthewRose

Line: 1 to 1
 
META TOPICPARENT name="MatthewRose"
LearningCurve MatthewRose

Improving ATLAS Trigger code

Line: 8 to 8
 

TrigEgammaHypo/

Added:
>
>
  • The following have been checked, except for forward declaration -- MatthewRose - 08 Jun 2010
    • TrigEgammaHypo/TrigEFDielectronMassFex.h checked, in accordance with TriggerCodingGuidelines
    • TrigEgammaHypo/TrigEFDiElectronMassHypo.h checked, in accordance with TriggerCodingGuidelines
    • TrigEgammaHypo/TrigEFElectronHypo.h checked, in accordance with TriggerCodingGuidelines
    • TrigEgammaHypo/TrigEFPhotonHypo.h checked, in accordance with TriggerCodingGuidelines
    • TrigEgammaHypo/TrigEFTrackHypo.h checked, in accordance with TriggerCodingGuidelines
    • TrigEgammaHypo/TrigL2CaloHypo.h checked, in accordance with TriggerCodingGuidelines
    • TrigEgammaHypo/TrigL2DielectronMassFex.h checked, in accordance with TriggerCodingGuidelines
    • TrigEgammaHypo/TrigL2DiElectronMassHypo.h checked, in accordance with TriggerCodingGuidelines
    • TrigEgammaHypo/TrigL2ElectronFex.h checked, in accordance with TriggerCodingGuidelines
    • TrigEgammaHypo/TrigL2ElectronHypo.h checked, in accordance with TriggerCodingGuidelines
    • TrigEgammaHypo/TrigL2ElectronHypoMoni.h checked, in accordance with TriggerCodingGuidelines
    • TrigEgammaHypo/TrigEFPhotonFex.h checked, in accordance with TriggerCodingGuidelines
    • TrigEgammaHypo/TrigEFPhotonHypo.h checked, in accordance with TriggerCodingGuidelines
    • src/TrigEFCaloHypo.cxx checked, in accordance with TriggerCodingGuidelines
    • src/TrigEFDielectronMassFex.cxx checked, in accordance with TriggerCodingGuidelines
    • src/TrigEFDiElectronMassHypo.cxx checked, in accordance with TriggerCodingGuidelines
    • src/TrigEFElectronHypo.cxx checked, in accordance with TriggerCodingGuidelines
    • src/TrigEFPhotonHypo.cxx checked, in accordance with TriggerCodingGuidelines
    • src/TrigEFTrackHypo.cxx checked, in accordance with TriggerCodingGuidelines
    • src/TrigL2CaloHypo.cxx checked, in accordance with TriggerCodingGuidelines
    • src/TrigL2DielectronMassFex.cxx checked, in accordance with TriggerCodingGuidelines
    • src/TrigL2DiElectronMassHypo.cxx checked, in accordance with TriggerCodingGuidelines
    • src/TrigL2ElectronFex.cxx checked, in accordance with TriggerCodingGuidelines
    • src/TrigL2ElectronHypo.cxx checked, in accordance with TriggerCodingGuidelines
    • src/TrigL2ElectronHypoMoni.cxx checked, in accordance with TriggerCodingGuidelines
    • src/TrigEFPhotonFex.cxx checked, in accordance with TriggerCodingGuidelines
    • src/TrigEFPhotonHypo.cxx checked, in accordance with TriggerCodingGuidelines
 
Added:
>
>
  • TrigEgammaHypo/TrigEFCaloHypo.h checked, in accordance with TriggerCodingGuidelines -- MatthewRose - 01 Jun 2010
 
  • cmt/requirements: removed apply_pattern declare_joboptions line to remove CMT warning-- MatthewRose - 21 May 2010
  • cmt/requirements: on advice of checkreq.py, removed TrkExInterfaces, made CxxUtils & ITrackToVertex private - builds fine-- MatthewRose - 21 May 2010

Revision 1121 May 2010 - MatthewRose

Line: 1 to 1
 
META TOPICPARENT name="MatthewRose"
Changed:
<
<
>
>
LearningCurve MatthewRose
 

Improving ATLAS Trigger code

Added:
>
>
Editing trigger code to meet ATLAS coding guidelines

Changes Made

 
Changed:
<
<
  • Moved some stuff around to get more space, now having problems making. Get following error after a gmake:
#CMT---> (constituents.make) Starting TrigEgammaHypoLib
#CMT---> (TrigEgammaHypoLib.make) PEDANTIC: /afs/cern.ch/user/m/mrose/testarea/AtlasOffline-rel_0/InstallArea/include/TrigEgammaHypo/TrigEgammaHypo/TrigL2PhotonFex.h: No rule for such target
#CMT---> (TrigEgammaHypoLib.make) PEDANTIC: /afs/cern.ch/user/m/mrose/testarea/AtlasOffline-rel_0/InstallArea/include/TrigEgammaHypo/TrigEgammaHypo/TrigL2PhotonFex.h: Seems to be a missing file. Please check
make[3]: *** [/afs/cern.ch/user/m/mrose/testarea/AtlasOffline-rel_0/InstallArea/include/TrigEgammaHypo/TrigEgammaHypo/TrigL2PhotonFex.h] Error 2
make[2]: *** [TrigEgammaHypoLib] Error 2
make[1]: *** [common_target] Error 2
make: *** [check_config] Error 2
-- MatthewRose - 29 Apr 2010

  • CMT co Trigger/TrigHypothesis/TrigEgammaHypo to check out, use svn to commit changes-- MatthewRose - 15 Mar 2010
  • Solved problem, misunderstood things (requirements file referred to before source /afs/cern.ch...setup.sh) so setup required again if changed. Then get following:
   > ~/cmthome% source ~/cmthome/setup.sh -tag=dev,32,rel_0
   > ~/cmthome% echo $CMTPATH  
   /afs/cern.ch/user/m/mrose/testarea//AtlasOffline-rel_0:/afs/cern.ch/atlas/software/builds/nightlies/dev/AtlasOffline/rel_0
-- MatthewRose - 15 Mar 2010
  • Trying to set up 15.X.0 environment for testing, using this. Having issues with setup, getting errors like:
   > ~% source ~/cmthome/setup.sh                  
   AtlasLogin: Configuration problem - /afs/cern.ch/atlas/software/builds/AtlasOffline/rel_0 non-existent
-- MatthewRose - 08 Mar 2010

>
>

TrigEgammaHypo/

 
Changed:
<
<
>
>
  • cmt/requirements: removed apply_pattern declare_joboptions line to remove CMT warning-- MatthewRose - 21 May 2010
  • cmt/requirements: on advice of checkreq.py, removed TrkExInterfaces, made CxxUtils & ITrackToVertex private - builds fine-- MatthewRose - 21 May 2010
 
META FILEATTACHMENT attachment="queryReport-1.pdf" attr="" comment="Shift Timetable" date="1268067805" name="queryReport-1.pdf" path="queryReport-1.pdf" size="77412" stream="queryReport-1.pdf" user="Public.MatthewRose" version="1"

Revision 1021 May 2010 - MatthewRose

Line: 1 to 1
 
META TOPICPARENT name="MatthewRose"
Deleted:
<
<

Hours

Work Date Hours Days Notes
Shift (S) 22/02/2010   1 shadow DAQ
Shift (M)        
Shift (E)        
Shift (N) 14-15/04   2 completed
Shift (M)     18 booked
Shift (E)     15 booked
Shift (N)     9 booked
Shift total     44  
Service     4  

 

Improving ATLAS Trigger code

Revision 929 Apr 2010 - MatthewRose

Line: 1 to 1
 
META TOPICPARENT name="MatthewRose"
Added:
>
>

Hours

Work Date Hours Days Notes
Shift (S) 22/02/2010   1 shadow DAQ
Shift (M)        
Shift (E)        
Shift (N) 14-15/04   2 completed
Shift (M)     18 booked
Shift (E)     15 booked
Shift (N)     9 booked
Shift total     44  
Service     4  

 

Improving ATLAS Trigger code

Added:
>
>
  • Moved some stuff around to get more space, now having problems making. Get following error after a gmake:
#CMT---> (constituents.make) Starting TrigEgammaHypoLib
#CMT---> (TrigEgammaHypoLib.make) PEDANTIC: /afs/cern.ch/user/m/mrose/testarea/AtlasOffline-rel_0/InstallArea/include/TrigEgammaHypo/TrigEgammaHypo/TrigL2PhotonFex.h: No rule for such target
#CMT---> (TrigEgammaHypoLib.make) PEDANTIC: /afs/cern.ch/user/m/mrose/testarea/AtlasOffline-rel_0/InstallArea/include/TrigEgammaHypo/TrigEgammaHypo/TrigL2PhotonFex.h: Seems to be a missing file. Please check
make[3]: *** [/afs/cern.ch/user/m/mrose/testarea/AtlasOffline-rel_0/InstallArea/include/TrigEgammaHypo/TrigEgammaHypo/TrigL2PhotonFex.h] Error 2
make[2]: *** [TrigEgammaHypoLib] Error 2
make[1]: *** [common_target] Error 2
make: *** [check_config] Error 2
-- MatthewRose - 29 Apr 2010
 
  • CMT co Trigger/TrigHypothesis/TrigEgammaHypo to check out, use svn to commit changes-- MatthewRose - 15 Mar 2010
  • Solved problem, misunderstood things (requirements file referred to before source /afs/cern.ch...setup.sh) so setup required again if changed. Then get following:
Line: 19 to 46
 

Deleted:
<
<

Hours

Work Date Hours Days Notes
Shift (S) 22/02/2010   1 shadow DAQ
Shift (M)        
Shift (E)        
Shift (N) 14-15/04   2 completed
Shift (M)     18 booked
Shift (E)     15 booked
Shift (N)     9 booked
Shift total     44  
Service     4  

 
META FILEATTACHMENT attachment="queryReport-1.pdf" attr="" comment="Shift Timetable" date="1268067805" name="queryReport-1.pdf" path="queryReport-1.pdf" size="77412" stream="queryReport-1.pdf" user="Public.MatthewRose" version="1"

Revision 829 Apr 2010 - MatthewRose

Line: 1 to 1
 
META TOPICPARENT name="MatthewRose"

Improving ATLAS Trigger code

  • CMT co Trigger/TrigHypothesis/TrigEgammaHypo to check out, use svn to commit changes-- MatthewRose - 15 Mar 2010
Line: 23 to 23
 

Hours

Work Date Hours Days Notes
Changed:
<
<
Shift (E) 22/02/2010   1 shadow DAQ
Shift (N)        
>
>
Shift (S) 22/02/2010   1 shadow DAQ
Shift (M)        
Shift (E)        
Shift (N) 14-15/04   2 completed
Shift (M)     18 booked
Shift (E)     15 booked
Shift (N)     9 booked
Shift total     44  
 
Service     4  

Revision 715 Mar 2010 - MatthewRose

Line: 1 to 1
 
META TOPICPARENT name="MatthewRose"

Improving ATLAS Trigger code

Changed:
<
<
>
>
  • CMT co Trigger/TrigHypothesis/TrigEgammaHypo to check out, use svn to commit changes-- MatthewRose - 15 Mar 2010
 
  • Solved problem, misunderstood things (requirements file referred to before source /afs/cern.ch...setup.sh) so setup required again if changed. Then get following:
   > ~/cmthome% source ~/cmthome/setup.sh -tag=dev,32,rel_0
Line: 25 to 25
 
Work Date Hours Days Notes
Shift (E) 22/02/2010   1 shadow DAQ
Shift (N)        
Changed:
<
<
Service     3  
>
>
Service     4  
 

Revision 615 Mar 2010 - MatthewRose

Line: 1 to 1
 
META TOPICPARENT name="MatthewRose"

Improving ATLAS Trigger code

Added:
>
>
  • Solved problem, misunderstood things (requirements file referred to before source /afs/cern.ch...setup.sh) so setup required again if changed. Then get following:
   > ~/cmthome% source ~/cmthome/setup.sh -tag=dev,32,rel_0
   > ~/cmthome% echo $CMTPATH  
   /afs/cern.ch/user/m/mrose/testarea//AtlasOffline-rel_0:/afs/cern.ch/atlas/software/builds/nightlies/dev/AtlasOffline/rel_0
-- MatthewRose - 15 Mar 2010
 
  • Trying to set up 15.X.0 environment for testing, using this. Having issues with setup, getting errors like:
Changed:
<
<
[mrose@lxplus218]~% source ~/cmthome/setup.sh
>
>
> ~% source ~/cmthome/setup.sh
 
AtlasLogin
Configuration problem - /afs/cern.ch/atlas/software/builds/AtlasOffline/rel_0 non-existent
-- MatthewRose - 08 Mar 2010

Revision 508 Mar 2010 - MatthewRose

Line: 1 to 1
 
META TOPICPARENT name="MatthewRose"

Improving ATLAS Trigger code

Changed:
<
<
Starting on TrigEgammaHypo requirements file-- MatthewRose - 01 Mar 2010
>
>
  • Trying to set up 15.X.0 environment for testing, using this. Having issues with setup, getting errors like:
   [mrose@lxplus218]~% source ~/cmthome/setup.sh                  
   AtlasLogin: Configuration problem - /afs/cern.ch/atlas/software/builds/AtlasOffline/rel_0 non-existent
-- MatthewRose - 08 Mar 2010
 
Changed:
<
<
Learning how to validate changes here-- MatthewRose - 05 Mar 2010
>
>

 

Hours

Line: 12 to 19
 
Work Date Hours Days Notes
Shift (E) 22/02/2010   1 shadow DAQ
Shift (N)        
Changed:
<
<
Service 03/2010   2  
>
>
Service     3  

META FILEATTACHMENT attachment="queryReport-1.pdf" attr="" comment="Shift Timetable" date="1268067805" name="queryReport-1.pdf" path="queryReport-1.pdf" size="77412" stream="queryReport-1.pdf" user="Public.MatthewRose" version="1"

Revision 405 Mar 2010 - MatthewRose

Line: 1 to 1
 
META TOPICPARENT name="MatthewRose"

Improving ATLAS Trigger code

Starting on TrigEgammaHypo requirements file-- MatthewRose - 01 Mar 2010

Added:
>
>
Learning how to validate changes here-- MatthewRose - 05 Mar 2010
 

Hours

Work Date Hours Days Notes
Shift (E) 22/02/2010   1 shadow DAQ
Shift (N)        
Deleted:
<
<
Service 02/03/2010 4    
 \ No newline at end of file
Added:
>
>
Service 03/2010   2  

Revision 302 Mar 2010 - MatthewRose

Line: 1 to 1
 
META TOPICPARENT name="MatthewRose"

Improving ATLAS Trigger code

Line: 7 to 7
 

Hours

Changed:
<
<
Work Date Hours Days
Shift (E) 22/02/2010   1
Shift (N) 22/02/2010    
Service 02/03/2010 4  
>
>
Work Date Hours Days Notes
Shift (E) 22/02/2010   1 shadow DAQ
Shift (N)        
Service 02/03/2010 4    
 \ No newline at end of file

Revision 201 Mar 2010 - MatthewRose

Line: 1 to 1
 
META TOPICPARENT name="MatthewRose"

Improving ATLAS Trigger code

Starting on TrigEgammaHypo requirements file-- MatthewRose - 01 Mar 2010

Added:
>
>

Hours

Work Date Hours Days
Shift (E) 22/02/2010   1
Shift (N) 22/02/2010    
Service 02/03/2010 4  

Revision 101 Mar 2010 - MatthewRose

Line: 1 to 1
Added:
>
>
META TOPICPARENT name="MatthewRose"

Improving ATLAS Trigger code

Starting on TrigEgammaHypo requirements file-- MatthewRose - 01 Mar 2010

 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2020 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding RHUL Physics Department TWiki? Send feedback