Keeping track of tips etc. as I learn them

• TrigEFDielectronMassFex
  • Moved MsgStream, IToolSvc & StatusCode from header to cxx file -- MatthewRose - 11 Jun 2010

• TrigEFCaloHypo
  • Removed RecEmTauRoI, StoregateSvc & SystemOfUnits from includes in header
  • Forward declared TrigTimerSvc -- MatthewRose - 10 Jun 2010

• In, for example, TrigEFCaloHypo, can probably remove TrigTimerSvc, instead using base class. Look up IHistogramSvc, see if this can be done here too. Can remover RecEmTauRoi, CLHEP, StoreGateSvc, and use base class for TrigTimeAlgs. Any things only referred to as pointers can be forward declared, not inherited things.
• Do these files need <cmath> and other stuff? -- MatthewRose - 08 Jun 2010

• After chat with Simon, going through guidelines:
  • ssh into an lxplus5 node to use nightlies. Use devval tag. In emacs, use c-X-4-a to bring up ChangeLog
  • Check in LXR for reliances, or use eg. cmt show clients Trigger/TrigHypothesis/TrigEgammaHypo
  • Look for includes in header, can use forward declarations instead, moving includes to .cxx files
  • Ask Ricardo about need for dual_use_libraries
  • Probably no need to worry about statuscode bits
  • Documentation: key points are tools, services, edm (?) classes etc.
  • Ignore naming conventions for now
  • Use appropriate errors/error codes (see L170 of TrigEgammaEFCaloHypo for example
  • Can see changes in WebSVN, or use svn diff

• Moved some stuff around to get more space, now having problems making. Get following error after a gmake:

#CMT---> (constituents.make) Starting TrigEgammaHypoLib
#CMT---> (TrigEgammaHypoLib.make) PEDANTIC: /afs/cern.ch/user/m/mrose/testarea/AtlasOffline-rel_0/InstallArea/include/TrigEgammaHypo/TrigEgammaHypo/TrigL2PhotonFex.h: No rule for such target
#CMT---> (TrigEgammaHypoLib.make) PEDANTIC: /afs/cern.ch/user/m/mrose/testarea/AtlasOffline-rel_0/InstallArea/include/TrigEgammaHypo/TrigEgammaHypo/TrigL2PhotonFex.h: Seems to be a missing file. Please check
make[3]: *** [/afs/cern.ch/user/m/mrose/testarea/AtlasOffline-rel_0/InstallArea/include/TrigEgammaHypo/TrigEgammaHypo/TrigL2PhotonFex.h] Error 2
make[2]: *** [TrigEgammaHypoLib] Error 2
make[1]: *** [common_target] Error 2
make: *** [check_config] Error 2

• CMT co Trigger/TrigHypothesis/TrigEgammaHypo to check out, use svn to commit changes-- MatthewRose - 15 Mar 2010
• Solved problem, misunderstood things (requirements file referred to before source /afs/cern.ch...setup.sh) so setup required again if changed. Then get following:

   > ~/cmthome% source ~/cmthome/setup.sh -tag=dev,32,rel_0
   > ~/cmthome% echo $CMTPATH  
   /afs/cern.ch/user/m/mrose/testarea//AtlasOffline-rel_0:/afs/cern.ch/atlas/software/builds/nightlies/dev/AtlasOffline/rel_0

• Trying to set up 15.X.0 environment for testing, using this. Having issues with setup, getting errors like:

   > ~% source ~/cmthome/setup.sh                  
   AtlasLogin: Configuration problem - /afs/cern.ch/atlas/software/builds/AtlasOffline/rel_0 non-existent

• Learning how to validate changes here-- MatthewRose - 05 Mar 2010

• Starting on TrigEgammaHypo requirements file-- MatthewRose - 01 Mar 2010