TrigMC software release coordination: PTD's logbook - page for November 2018


Use the shift date in reverse chronological order to enter any new Merge Requests.

For each shift date show the NEW MRs, and any related relevant comments/questions; note down when I (or some one else) merged/closed each request, and mark the MR as done/closed by ticking the box ([x]). If an MR takes longer than a day to merge, leave it listed under the original shift date, but add comments prefaced with the date of the comment/action. Only MRs that are still active should have the box unticked ([ ]).

Therefore each MR will only appear once in the log, under the date of the day when I first became aware of it.

Requests still open:


[ ] !NNNNN Title (opened by XYZ)


[x] !16111 Sweeping 16092 from 21.1 to 21.0-TrigMC. Fix to command in trigger ART tests (opened by Atlas Nightlybuild)

9.07am This MR is an automatic consequence of !16092 (see below). CI pipeline ran OK. Review-approved label. Merged OK.


[x] !16092 Fix to command in trigger ART tests (opened by Julie Kirk)

3.33pm Opened an hour ago. MR is for 21.1, but carries the label "alsoTargeting:21.0-TrigMC". This means I don't need to approve/merge it myself (someone else will), but expect the MR to be applied automatically to 21.0-TrigMC in the 24hrs following merging into 21.1.


11.53am Checked the nightly on NICOS: all looks good.

[x] !15975 Sweeping 15910 from 21.1 to 21.0-TrigMC. fixes for trigger ART test monitoring (opened by Atlas Nightlybuild)

11.30am MR opened automatically overnight. CI pipeline finished OK. As this is a sweep of a previous MR, it is "safe" to merge, despite review-pending label. Merged OK.


[x] !15889 Merge branch 'ARTtestError' into '21.1' (opened by Julie Hart Kirk)

10.43am Request opened a few minutes ago. CI pipeline has just started running. Title of MR is slightly weird (?), as it mentions 21.1... not 21.0-TrigMC...?

1.57pm Julie has confirmed that this is a cherry-pick of a previous MR (entitled "Merge branch 'ARTtestError' into '21.1' "), now being applied to 21.0-TrigMC. She has updated the title accordingly, to clarify.

15/11/2018 12.35pm The MR has now been review-approved. Merged OK.


10.37am Had a quick look at the latest nightly, following on from the two MRs yesterday. (Not available on the ART page: still issues with it...) From the NICOS pages, it looks like there are no differences (as far as building and testing) between the latest nightly and the one form the previous nights.


[x] !15734 time prints the full cmd line before real..user..sys (for branch 21.0-TrigMC) (opened by Oleg Zenin)

10.40am Request opened yesterday night. The pipeline has concluded OK. A JIRA thread is mentioned: it is long and detailed, and is "watched" by recognised experts (Obreshkov, Undrus); I therefore believe the issue has been ironed out and there has been convergence on a fully worked-out solution. Happy to merge, despite L1-review still pending. Merged OK.

[x] !15726 ATR-19044: bug in Run-1-style taggers in the split configuration (opened by Carlo Varni)

10.26am This MR was opened yesterday evening. The pipeline has passed. However: the review-pending-L1 label was never applied (I have never seen this on an MR before...), so there has been no L1 shifter review. Also: the JIRA ticket does not add anything; it was not watched by any of the usual experts (only the author and one other colleague). The requester states on the MR that it is a simple bug fix with no consequences on other triggers. I have looked at the actual committed changes, and they do indeed look like a simple bug fix, nothing complicated... Therefore will risk Merging it without explicit L1 shifter approval... Merged OK.

-- PedroTeixeiraDias - 31 Oct 2018

This topic: Public > UserList > PedroTeixeiraDias > PTD_TrigMC_LogBook_2018 > TrigMC_Log2018_11
Topic revision: r9 - 21 Nov 2018 - PedroTeixeiraDias
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2022 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding RHUL Physics Department TWiki? Send feedback